Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reenable integration tests in ACVM #4050

Merged
merged 1 commit into from
Jan 16, 2024
Merged

chore: reenable integration tests in ACVM #4050

merged 1 commit into from
Jan 16, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #3802

Summary*

This PR enables these ignored tests.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title chore: reenable tests in ACVM chore: reenable integration tests in ACVM Jan 16, 2024
@kevaundray kevaundray added this pull request to the merge queue Jan 16, 2024
Merged via the queue into master with commit a3b162b Jan 16, 2024
31 checks passed
@kevaundray kevaundray deleted the tf/enable-tests branch January 16, 2024 18:34
AztecBot pushed a commit that referenced this pull request Jan 24, 2024
@guipublic @kevaundray @AztecBot
feat!: Add big int opcodes (without implementation) (#4050)
7dba0a1 
Adds the biginteger opcode skeleton
#4040

The PR adds ACIR opcodes for bigint operations. It does not provide any
implantation of the opcodes, neither in BB, in the solver or in Brillig.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable ignored tests
2 participants
@TomAFrench @kevaundray